Migrated connectField tests to @testing-library/react
#1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpospiech
requested review from
wadamek65 and
kestarumper
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 231 231
Lines 3821 3821
Branches 1029 1029
=======================================
Hits 3617 3617
Misses 82 82
Partials 122 122 ☔ View full report in Codecov by Sentry. |
kestarumper
requested changes
Feb 15, 2024
kestarumper
previously approved these changes
Feb 15, 2024
kestarumper
requested changes
Feb 20, 2024
| [undefined, '', ''], | ||
| [undefined, 'Schema', 'Schema'], | ||
| [undefined, labelB, labelB], | ||
| [undefined, undefined, ''], |
There was a problem hiding this comment.
Why did you remove those cases?
There was a problem hiding this comment.
I created Test component that use label as input props and it couldn't be rendered.
I changed it now to render label above input. Rendering label is based on rendering label in TextField in the uniforms-unstyled. I needed to change works with nested labels test after this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is part of #1130
connectFieldRTL testsconnectFieldtestsMain changes compare to
enzymetests:when rendered with labeltest followinglabelVariants:is able to set another field valuetest, tested value fromobjecttostringto have the same type in those two fields